[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-commits] [COMMIT 5d02482] linux-user: fix old style decrement
|
From: |
Stuart Brady |
|
Subject: |
Re: [Qemu-commits] [COMMIT 5d02482] linux-user: fix old style decrement usage |
|
Date: |
Thu, 1 Oct 2009 00:07:37 +0100 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Wed, Sep 30, 2009 at 11:57:01PM +0200, Laurent Desnogues wrote:
> On Wed, Sep 30, 2009 at 9:01 PM, Anthony Liguori <address@hidden> wrote:
> > - nRc=-get_float_exception_flags(&fpa11->fp_status);
> > + nRc -= get_float_exception_flags(&fpa11->fp_status);
>
> Are you sure this is correct?
[snip]
> And nRc isn't zero here. So the semantics has changed.
I think a change in semantics was intended, but the caller negates the
value if it is negative, so I'm fairly sure that this should be:
nRc = -get_float_exception_flags(&fpa11->fp_status);
I suppose spaces before and after '=' are a good idea. :)
Cheers,
--
Stuart Brady