Re: [Qemu-commits] [COMMIT fe6549d] This files are compiled in libqemu.a now

[Stefan Weil]

Anthony Liguori schrieb:
> From: Juan Quintela <address@hidden>
>
> This fixes compilation of linux-user with today qemu, please apply.
>
> Signed-off-by: Juan Quintela <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
>
> diff --git a/Makefile.target b/Makefile.target
> index a9bdf20..0ebef17 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -83,7 +83,6 @@ QEMU_CFLAGS+=-I$(SRC_PATH)/linux-user
> -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
> obj-y = main.o syscall.o strace.o mmap.o signal.o thunk.o \
> elfload.o linuxload.o uaccess.o gdbstub.o gdbstub-xml.o
> obj-y += envlist.o path.o
> -obj-y += tcg-runtime.o host-utils.o
>
> obj-$(TARGET_HAS_BFLT) += flatload.o
> obj-$(TARGET_HAS_ELFLOAD32) += elfload32.o
> @@ -118,7 +117,6 @@ LIBS+=-lmx
> obj-y = main.o commpage.o machload.o mmap.o signal.o syscall.o thunk.o \
> gdbstub.o gdbstub-xml.o
> obj-y += envlist.o path.o
> -obj-y += tcg-runtime.o host-utils.o
>
> obj-i386-y += ioport-user.o
>
> @@ -137,7 +135,6 @@ QEMU_CFLAGS+=-I$(SRC_PATH)/bsd-user
> -I$(SRC_PATH)/bsd-user/$(TARGET_ARCH)
> obj-y = main.o bsdload.o elfload.o mmap.o signal.o strace.o syscall.o \
> gdbstub.o gdbstub-xml.o uaccess.o
> obj-y += envlist.o path.o
> -obj-y += tcg-runtime.o host-utils.o
>
> obj-i386-y += ioport-user.o 


tcg-runtime.o and host-utils.o are needed for 64-bit linux-user targets
on 32 bit hosts, and they are not part of libqemu.a there.

So the patch breaks linking of linux-user on 32 bit hosts.

Regards
Stefan Weil


log extract:

LINK x86_64-linux-user/qemu-x86_64
libqemu.a(translate.o): In function `tcg_gen_helper64':
/home/stefan/src/qemu/tcg/tcg-op.h:347: undefined reference to
`tcg_helper_shr_i64'
...
libqemu.a(op_helper.o): In function `helper_imulq_T0_T1':
/home/stefan/src/qemu/target-i386/op_helper.c:4601:: undefined reference
to `muls64'
...