qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 73538c3] Suppress kraxelisms


From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 73538c3] Suppress kraxelisms
Date: Fri, 28 Aug 2009 19:17:39 -0000

From: Blue Swirl <address@hidden>

Signed-off-by: Blue Swirl <address@hidden>

diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index 85ba354..2843b51 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -137,10 +137,12 @@ ISADevice *isa_create_simple(const char *name, uint32_t 
iobase, uint32_t iobase2
     isa->iobase[0] = iobase;
     isa->iobase[1] = iobase2;
     qdev_init(dev);
-    if (-1 != irq)
+    if (irq != -1) {
         isa_connect_irq(isa, 0, irq);
-    if (-1 != irq2)
+    }
+    if (irq2 != -1) {
         isa_connect_irq(isa, 1, irq2);
+    }
     return isa;
 }
 
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index c9703c2..12ff46b 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -273,7 +273,7 @@ static int print_pci_devfn(DeviceState *dev, Property 
*prop, char *dest, size_t
 {
     uint32_t *ptr = qdev_get_prop_ptr(dev, prop);
 
-    if (-1 == *ptr) {
+    if (*ptr == -1) {
         return snprintf(dest, len, "<unset>");
     } else {
         return snprintf(dest, len, "%02x.%x", *ptr >> 3, *ptr & 7);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]