qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT c66b57f] Fix checksum writing in signboot.sh


From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT c66b57f] Fix checksum writing in signboot.sh
Date: Mon, 10 Aug 2009 21:48:13 -0000

From: Alexander Graf <address@hidden>

The printf command takes an octal value after \, so we have to convert
our decimal representation to octal first and then write it.

This unbreaks extboot signing. Multiboot wasn't affected yet because
the checksum was < 8.

Spotted and first patch by Glauber Costa <address@hidden>.
Printf idea by Paolo Bonzini <address@hidden>.

Signed-off-by: Alexander Graf <address@hidden>
CC: Glauber Costa <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Jan Ondrej <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
Message-Id: 

diff --git a/pc-bios/optionrom/signrom.sh b/pc-bios/optionrom/signrom.sh
index 4322811..975b27d 100755
--- a/pc-bios/optionrom/signrom.sh
+++ b/pc-bios/optionrom/signrom.sh
@@ -39,7 +39,8 @@ done
 
 sum=$(( $sum % 256 ))
 sum=$(( 256 - $sum ))
+sum_octal=$( printf "%o" $sum )
 
 # and write the output file
 cp "$1" "$2"
-printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null
+printf "\\$sum_octal" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 
2>/dev/null




reply via email to

[Prev in Thread] Current Thread [Next in Thread]