Re: [Qemu-commits] [COMMIT 74d753a] linux-user: strace now handles guest stringscorrectly [v2]

[malc]

On Wed, 17 Jun 2009, Riku Voipio wrote:

> On Wed, Jun 17, 2009 at 10:43:44PM +0400, malc wrote:
> > On Wed, 17 Jun 2009, Riku Voipio wrote:
> > > It doesn't look like your kernel headers have been sanitized beforing 
> > > installing.
> > > futex.h exposed to userspace shouldn't have __user anywhere.
> 
> > > Previously distros did that by hand, nowadays you can do a "make 
> > > headers_install"
> > > in the kernel tree itself.
> 
> > FWIW adding #include <linux/compiler.h> which defines some of those also
> > fixes things for me.
> 
> We already have been including futex.h from syscall.c for some time. Could
> you check if any of the headers included before futex.h there define the
> needed __user/u32 on your distribution?

__user
signal.h -> bits/sigcontext.h -> asm/sigcontext.h -> linux/compiler.h 

u32
linux/termios.h -> linux/types.h -> asm/types.h

-- 
mailto:address@hidden