qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-commits] [COMMIT 74d753a] linux-user: strace now handles guest


From: malc
Subject: Re: [Qemu-commits] [COMMIT 74d753a] linux-user: strace now handles guest stringscorrectly [v2]
Date: Wed, 17 Jun 2009 22:44:33 +0400 (MSD)

On Wed, 17 Jun 2009, Laurent Desnogues wrote:

> On Wed, Jun 17, 2009 at 9:18 AM, Riku Voipio<address@hidden> wrote:
> > On Wed, Jun 17, 2009 at 02:27:06AM +0400, malc wrote:
> >> On Tue, 16 Jun 2009, Anthony Liguori wrote:
> >> On my system the above line causes gcc to emit:
> >
> >> In file included from /home/malc/x/rcs/git/qemu/linux-user/strace.c:12:
> >> /usr/include/linux/futex.h:48: error: field `__user' has incomplete type
> >> /usr/include/linux/futex.h:48: error: syntax error before '*' token
> >> /usr/include/linux/futex.h:63: error: field `list' has incomplete type
> >> /usr/include/linux/futex.h:83: error: field `__user' has incomplete type
> >> /usr/include/linux/futex.h:83: error: syntax error before '*' token
> >> make[1]: *** [strace.o] Error 1
> >
> >> Following fixes it, but i wonder if there's better way:
> >
> > It doesn't look like your kernel headers have been sanitized beforing 
> > installing.
> > futex.h exposed to userspace shouldn't have __user anywhere.
> >
> > Previously distros did that by hand, nowadays you can do a "make 
> > headers_install"
> > in the kernel tree itself.
> 
> I got something different on my CentOS 5.3 x86_64:
> 
> /usr/include/linux/futex.h:108: error: expected ?)? before ?*? token
> /usr/include/linux/futex.h:112: error: expected ?)? before ?*? token
> 
> Apparently it lacks u32 definition.
> 

u32 should never be exposed to userspace IIRC, that's what __u32 and
friends are for.

-- 
mailto:address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]