[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-commits] [COMMIT aca312a] qdev: kill DeviceState->name
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-commits] [COMMIT aca312a] qdev: kill DeviceState->name |
|
Date: |
Wed, 10 Jun 2009 00:29:12 +0100 |
|
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
> The visibility of both "name" member variables is different:
> the removed one was defined in a header file (so it
> was public), the remaining one is only defined locally
> in qdev.c (it is private).
As the comments is qdev.h state, this is not a public API. You should not be
accessing any of the DeviceState fields directly.
> What about defining the full DeviceType struct in qdev.h?
> I have code which reads "name" (a newer version of eepro100.c),
> and it was broken by this commit...
My guess would be this is a symptom of you doing something else wrong.
Paul