qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 7050326] Win32: Don't remove const attribute in t


From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 7050326] Win32: Don't remove const attribute in type casts.
Date: Sat, 13 Jun 2009 11:34:53 -0000

From: Stefan Weil <address@hidden>

Type casts removing the const attribute are bad because
they hide the fact that the argument remains const.

They also result in a compiler warning (at least with MS-C).

Signed-off-by: Stefan Weil <address@hidden>

diff --git a/net.c b/net.c
index 58d68b5..af9de73 100644
--- a/net.c
+++ b/net.c
@@ -1507,7 +1507,7 @@ static ssize_t net_socket_receive_dgram(VLANClientState 
*vc, const uint8_t *buf,
 {
     NetSocketState *s = vc->opaque;
 
-    return sendto(s->fd, (void *)buf, size, 0,
+    return sendto(s->fd, (const void *)buf, size, 0,
                   (struct sockaddr *)&s->dgram_dst, sizeof(s->dgram_dst));
 }
 
diff --git a/qemu-char.c b/qemu-char.c
index a63d860..a8afe94 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1708,7 +1708,7 @@ static int udp_chr_write(CharDriverState *chr, const 
uint8_t *buf, int len)
 {
     NetCharDriver *s = chr->opaque;
 
-    return sendto(s->fd, (void *)buf, len, 0,
+    return sendto(s->fd, (const void *)buf, len, 0,
                   (struct sockaddr *)&s->daddr, sizeof(struct sockaddr_in));
 }
 
diff --git a/vnc.c b/vnc.c
index 109c2f3..e1ca9f8 100644
--- a/vnc.c
+++ b/vnc.c
@@ -961,7 +961,7 @@ long vnc_client_write_buf(VncState *vs, const uint8_t 
*data, size_t datalen)
         }
     } else
 #endif /* CONFIG_VNC_TLS */
-        ret = send(vs->csock, (void *)data, datalen, 0);
+        ret = send(vs->csock, (const void *)data, datalen, 0);
     VNC_DEBUG("Wrote wire %p %zd -> %ld\n", data, datalen, ret);
     return vnc_client_io_error(vs, ret, socket_error());
 }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]