[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [COMMIT d91d9bf] monitor: Remove uneeded goto
From: |
Anthony Liguori |
Subject: |
[Qemu-commits] [COMMIT d91d9bf] monitor: Remove uneeded goto |
Date: |
Wed, 10 Jun 2009 17:00:39 -0000 |
From: Luiz Capitulino <address@hidden>
The 'found' goto in monitor_handle_command() can be dropped if we check
for 'cmd->name' after looking up for the command to execute.
Signed-off-by: Luiz Capitulino <address@hidden>
diff --git a/monitor.c b/monitor.c
index 7620bde..fd91752 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2432,11 +2432,13 @@ static void monitor_handle_command(Monitor *mon, const
char *cmdline)
/* find the command */
for(cmd = mon_cmds; cmd->name != NULL; cmd++) {
if (compare_cmd(cmdname, cmd->name))
- goto found;
+ break;
+ }
+
+ if (cmd->name == NULL) {
+ monitor_printf(mon, "unknown command: '%s'\n", cmdname);
+ return;
}
- monitor_printf(mon, "unknown command: '%s'\n", cmdname);
- return;
- found:
for(i = 0; i < MAX_ARGS; i++)
str_allocated[i] = NULL;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [COMMIT d91d9bf] monitor: Remove uneeded goto,
Anthony Liguori <=