Re: [Qemu-commits] [COMMIT 5561650] Include assert.h from qemu-common.h

[Stefan Weil]

Anthony Liguori schrieb:
> From: Paul Brook <address@hidden>
>
> Include assert.h from qemu-common.h and remove other direct uses.
> cpu-all.h still need to include it because of the dyngen-exec.h hacks
>
> Signed-off-by: Paul Brook <address@hidden>
> ...
> diff --git a/target-sh4/translate.c b/target-sh4/translate.c
> index fc3633a..1f461b7 100644
> --- a/target-sh4/translate.c
> +++ b/target-sh4/translate.c
> @@ -22,7 +22,6 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <inttypes.h>
>   

These can be removed, too (they are already included in qemu-common.h).

> -#include <assert.h>
>  
>  #define DEBUG_DISAS
>  #define SH4_DEBUG_DISAS
> diff --git a/target-sparc/helper.c b/target-sparc/helper.c
> index 8ad82a9..2f41418 100644
> --- a/target-sparc/helper.c
> +++ b/target-sparc/helper.c
> @@ -23,7 +23,6 @@
>  #include <string.h>
>  #include <inttypes.h>
>  #include <signal.h>
>   

Dto.

>   
> -#include <assert.h>
>  
>  #include "cpu.h"
>  #include "exec-all.h"
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a75d8dc..299bff6 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -32,7 +32,6 @@
>  #define NDEBUG
>  #endif
>  
> -#include <assert.h>
>  #include <stdarg.h>
>  #include <stdlib.h>
>  #include <stdio.h>
>   

Dto.

qemu-common.h includes most of the typical standard headers,
so they might be removed from all QEMU source files which
include qemu-common.h.

Stefan