[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 24/27] qapi transaction: Elide redundant has_FOO in generated C
From: |
Markus Armbruster |
Subject: |
[PATCH 24/27] qapi transaction: Elide redundant has_FOO in generated C |
Date: |
Thu, 15 Sep 2022 22:43:14 +0200 |
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/transaction.json.
Said commit explains the transformation in more detail. The invariant
violations mentioned there do not occur here.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
blockdev.c | 3 +--
scripts/qapi/schema.py | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index c1259f6bf1..9aac4e057c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1039,7 +1039,7 @@ static void blockdev_do_action(TransactionAction *action,
Error **errp)
list.value = action;
list.next = NULL;
- qmp_transaction(&list, false, NULL, errp);
+ qmp_transaction(&list, NULL, errp);
}
void qmp_blockdev_snapshot_sync(const char *device, const char *node_name,
@@ -2293,7 +2293,6 @@ static TransactionProperties *get_transaction_properties(
* Always run under BQL.
*/
void qmp_transaction(TransactionActionList *dev_list,
- bool has_props,
struct TransactionProperties *props,
Error **errp)
{
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 2bec0588c8..7fb24c2e5b 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -759,7 +759,6 @@ def need_has(self):
assert self.type
# Temporary hack to support dropping the has_FOO in reviewable chunks
opt_out = [
- 'qapi/transaction.json',
'qapi/ui.json',
'qga/qapi-schema.json']
if self.info and any(self.info.fname.endswith(mod)
--
2.37.2