[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based
From: |
Raphael Norwitz |
Subject: |
Re: [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based on features |
Date: |
Wed, 7 Sep 2022 04:02:25 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Thanks for the changes. For the whole series:
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
On Tue, Sep 06, 2022 at 10:31:06AM +0300, Daniil Tatianin wrote:
> This patch set attempts to align vhost-user-blk with virtio-blk in
> terms of backward compatibility and flexibility. It also improves
> the virtio core by introducing new common code that can be used by
> a virtio device to calculate its config space size.
>
> In particular it adds the following things:
> - Common virtio code for deducing the required device config size based
> on provided host features.
> - Ability to disable modern virtio-blk features like
> discard/write-zeroes for vhost-user-blk.
> - Dynamic configuration space resizing based on enabled features,
> by reusing the common code introduced in the earlier commits.
> - Cleans up the VHostUserBlk structure by reusing parent fields.
>
> Changes since v1 (mostly addresses Stefan's feedback):
> - Introduce VirtIOConfigSizeParams & virtio_get_config_size
> - Remove virtio_blk_set_config_size altogether, make virtio-blk-common.c
> only hold the virtio-blk config size parameters.
> - Reuse parent fields in vhost-user-blk instead of introducing new ones.
>
> Changes since v2:
> - Squash the first four commits into one
> - Set .min_size for virtio-net as well
> - Move maintainer/meson user-blk bits to the last commit
>
> Daniil Tatianin (5):
> virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size
> virtio-blk: move config size params to virtio-blk-common
> vhost-user-blk: make it possible to disable write-zeroes/discard
> vhost-user-blk: make 'config_wce' part of 'host_features'
> vhost-user-blk: dynamically resize config space based on features
>
> MAINTAINERS | 4 +++
> hw/block/meson.build | 4 +--
> hw/block/vhost-user-blk.c | 29 +++++++++++---------
> hw/block/virtio-blk-common.c | 39 +++++++++++++++++++++++++++
> hw/block/virtio-blk.c | 28 +++----------------
> hw/net/virtio-net.c | 9 +++++--
> hw/virtio/virtio.c | 10 ++++---
> include/hw/virtio/vhost-user-blk.h | 1 -
> include/hw/virtio/virtio-blk-common.h | 20 ++++++++++++++
> include/hw/virtio/virtio.h | 10 +++++--
> 10 files changed, 105 insertions(+), 49 deletions(-)
> create mode 100644 hw/block/virtio-blk-common.c
> create mode 100644 include/hw/virtio/virtio-blk-common.h
>
> --
> 2.25.1
>
- [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based on features, Daniil Tatianin, 2022/09/06
- [PATCH v3 1/5] virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size, Daniil Tatianin, 2022/09/06
- [PATCH v3 3/5] vhost-user-blk: make it possible to disable write-zeroes/discard, Daniil Tatianin, 2022/09/06
- [PATCH v3 2/5] virtio-blk: move config size params to virtio-blk-common, Daniil Tatianin, 2022/09/06
- [PATCH v3 5/5] vhost-user-blk: dynamically resize config space based on features, Daniil Tatianin, 2022/09/06
- [PATCH v3 4/5] vhost-user-blk: make 'config_wce' part of 'host_features', Daniil Tatianin, 2022/09/06
- Re: [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based on features,
Raphael Norwitz <=