[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 04/13] hw/isa/vt82c686: Reuse errp
From: |
Bernhard Beschow |
Subject: |
[PATCH v5 04/13] hw/isa/vt82c686: Reuse errp |
Date: |
Thu, 1 Sep 2022 13:41:18 +0200 |
Rather than terminating abruptly, make use of the already present errp and
propagate the error to the caller.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/isa/vt82c686.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 5582c0b179..37e37b3855 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -590,7 +590,12 @@ static void via_isa_realize(PCIDevice *d, Error **errp)
qdev_init_gpio_out(dev, &s->cpu_intr, 1);
isa_irq = qemu_allocate_irqs(via_isa_request_i8259_irq, s, 1);
isa_bus = isa_bus_new(dev, pci_address_space(d), pci_address_space_io(d),
- &error_fatal);
+ errp);
+
+ if (!isa_bus) {
+ return;
+ }
+
s->isa_irqs = i8259_init(isa_bus, *isa_irq);
isa_bus_irqs(isa_bus, s->isa_irqs);
i8254_pit_init(isa_bus, 0x40, 0, NULL);
--
2.37.3
- Re: [PATCH v5 13/13] hw/isa/vt82c686: Create rtc-time alias in boards instead, (continued)
- [PATCH v5 06/13] hw/isa/vt82c686: Instantiate IDE function in host device, Bernhard Beschow, 2022/09/01
- [PATCH v5 10/13] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device, Bernhard Beschow, 2022/09/01
- [PATCH v5 12/13] hw/isa/vt82c686: Embed RTCState in host device, Bernhard Beschow, 2022/09/01
- [PATCH v5 05/13] hw/isa/vt82c686: Introduce TYPE_VIA_IDE define, Bernhard Beschow, 2022/09/01
- [PATCH v5 01/13] hw/isa/vt82c686: Resolve chip-specific realize methods, Bernhard Beschow, 2022/09/01
- [PATCH v5 04/13] hw/isa/vt82c686: Reuse errp,
Bernhard Beschow <=
- [PATCH v5 02/13] hw/isa/vt82c686: Resolve unneeded attribute, Bernhard Beschow, 2022/09/01
- [PATCH v5 07/13] hw/isa/vt82c686: Introduce TYPE_VT82C686B_USB_UHCI define, Bernhard Beschow, 2022/09/01
- [PATCH v5 03/13] hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory(), Bernhard Beschow, 2022/09/01
- [PATCH v5 11/13] hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it, Bernhard Beschow, 2022/09/01
- [PATCH v5 09/13] hw/isa/vt82c686: Instantiate PM function in host device, Bernhard Beschow, 2022/09/01
- [PATCH v5 08/13] hw/isa/vt82c686: Instantiate USB functions in host device, Bernhard Beschow, 2022/09/01