qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] piix_ide_reset: Use pci_set_* functions instead of direc


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/4] piix_ide_reset: Use pci_set_* functions instead of direct access
Date: Mon, 30 May 2022 15:24:14 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 28/5/22 22:47, Lev Kujawski wrote:
Eliminates the remaining TODOs in hw/ide/piix.c by:
- Using pci_set_{size} functions to write the PIIX PCI configuration
   space instead of manipulating it directly as an array; and
- Documenting default register values by reference to the controlling
   specification.

Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
---
  hw/ide/piix.c | 17 +++++++++--------
  1 file changed, 9 insertions(+), 8 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]