Re: [PATCH] qsd: document vduse-blk exports

[Stefan Hajnoczi]

On Fri, May 27, 2022 at 05:54:12PM +0200, Kevin Wolf wrote:
> Am 26.05.2022 um 13:36 hat Yongji Xie geschrieben:
> > On Wed, May 25, 2022 at 8:19 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > Document vduse-blk exports in qemu-storage-daemon --help and the
> > > qemu-storage-daemon(1) man page.
> > >
> > > Based-on: <20220523084611.91-1-xieyongji@bytedance.com>
> > > Cc: Xie Yongji <xieyongji@bytedance.com>
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> > > @@ -110,6 +111,26 @@ Standard options:
> > >    ``allow-other`` to auto (the default) will try enabling this option, 
> > > and on
> > >    error fall back to disabling it.
> > >
> > > +  The ``vduse-blk`` export type uses the ``id`` as the VDUSE device name.
> > > +  ``num-queues`` sets the number of virtqueues (the default is 1).
> > > +  ``queue-size`` sets the virtqueue descriptor table size (the default 
> > > is 256).
> > > +
> > > +  The instantiated VDUSE device must then be added to the vDPA bus using 
> > > the
> > > +  vdpa(8) command from the iproute2 project::
> > > +
> > > +  # vdpa dev add <id> mgmtdev vduse
> > 
> > Should it be:
> > 
> > # vdpa dev add name <id> mgmtdev vduse
> 
> Thanks, fixed this up (as well as a missing "\n" in the help output) and
> applied to the block branch.

Thanks!

Stefan

signature.asc
Description: PGP signature