[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ide_ioport_read: Return lower octet of data register instead
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] ide_ioport_read: Return lower octet of data register instead of 0xFF |
|
Date: |
Tue, 24 May 2022 11:52:28 +0200 |
Queued, thanks. The same change needs to be done in hw/ide/macio.c:
diff --git a/hw/ide/macio.c b/hw/ide/macio.c
index f08318cf97..1c15c37ec5 100644
--- a/hw/ide/macio.c
+++ b/hw/ide/macio.c
@@ -267,7 +267,9 @@ static uint64_t pmac_ide_read(void *opaque, hwaddr addr,
unsigned size)
switch (reg) {
case 0x0:
- if (size == 2) {
+ if (size == 1) {
+ retval = ide_data_readw(&d->bus, 0) & 0xFF;
+ } else if (size == 2) {
retval = ide_data_readw(&d->bus, 0);
} else if (size == 4) {
retval = ide_data_readl(&d->bus, 0);
while (unintentionally) hw/ide/mmio.c already works fine.
Paolo