[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/10] crypto: Make block callbacks return 0 on success
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2 04/10] crypto: Make block callbacks return 0 on success |
|
Date: |
Tue, 17 May 2022 09:26:13 -0500 |
|
User-agent: |
NeoMutt/20220429-68-cedf86 |
On Fri, May 13, 2022 at 04:57:43PM +0100, Alberto Faria wrote:
> They currently return the value of their headerlen/buflen parameter on
> success. Returning 0 instead makes it clear that short reads/writes are
> not possible.
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
> block/crypto.c | 52 +++++++++++++++++-----------------
> block/qcow2.c | 22 +++++++-------
> crypto/block-luks.c | 8 +++---
> crypto/block.c | 6 ++--
> include/crypto/block.h | 32 ++++++++++-----------
> tests/unit/test-crypto-block.c | 38 ++++++++++++-------------
> 6 files changed, 79 insertions(+), 79 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/05/13
- [PATCH v2 01/10] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}(), Alberto Faria, 2022/05/13
- [PATCH v2 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order, Alberto Faria, 2022/05/13
- [PATCH v2 05/10] block: Make bdrv_co_pwrite() take a const buffer, Alberto Faria, 2022/05/13
- [PATCH v2 07/10] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/05/13
- [PATCH v2 08/10] block: Add bdrv_co_pwrite_sync(), Alberto Faria, 2022/05/13
- [PATCH v2 04/10] crypto: Make block callbacks return 0 on success, Alberto Faria, 2022/05/13
- Re: [PATCH v2 04/10] crypto: Make block callbacks return 0 on success,
Eric Blake <=
- [PATCH v2 09/10] block: Use bdrv_co_pwrite_sync() when caller is coroutine_fn, Alberto Faria, 2022/05/13
- [PATCH v2 03/10] block: Make bdrv_{pread, pwrite}() return 0 on success, Alberto Faria, 2022/05/13
- [PATCH v2 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty(), Alberto Faria, 2022/05/13
- [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Alberto Faria, 2022/05/13
- Re: [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Eric Blake, 2022/05/17
- Re: [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Alberto Faria, 2022/05/17
- Re: [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Eric Blake, 2022/05/18