[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/nvme: fix smart aen
From: |
Klaus Jensen |
Subject: |
Re: [PATCH] hw/nvme: fix smart aen |
Date: |
Thu, 12 May 2022 07:39:42 +0200 |
On May 6 08:36, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Pass the right constant to nvme_smart_event(). The NVME_AER* values hold
> the bit position in the SMART byte, not the shifted value that we expect
> it to be in nvme_smart_event().
>
> Fixes: c62720f137df ("hw/block/nvme: trigger async event during injecting
> smart warning")
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 08574c4dcbc8..a2f6069f7fe1 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -5325,7 +5325,7 @@ static uint16_t nvme_set_feature(NvmeCtrl *n,
> NvmeRequest *req)
>
> if ((n->temperature >= n->features.temp_thresh_hi) ||
> (n->temperature <= n->features.temp_thresh_low)) {
> - nvme_smart_event(n, NVME_AER_INFO_SMART_TEMP_THRESH);
> + nvme_smart_event(n, NVME_SMART_TEMPERATURE);
> }
>
> break;
> --
> 2.36.0
>
Applied to nvme-next.
signature.asc
Description: PGP signature