qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Re: [PATCH 0/2] hw/nvme: support smart AEN


From: zhenwei pi
Subject: Re: Re: [PATCH 0/2] hw/nvme: support smart AEN
Date: Mon, 9 May 2022 20:36:56 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 5/9/22 19:12, Klaus Jensen wrote:
On May  7 15:26, zhenwei pi wrote:
Hi,
In this series, firstly introduce smart related bits of aen cfg, then
support this in oaes.

Linux guest does not support this currently, I also send a series to
enable smart AEN:
https://lore.kernel.org/lkml/20220507065026.260306-1-pizhenwei@bytedance.com/T/#t

Test the two series together, works fine.

Zhenwei Pi (2):
   hw/nvme: introduce smart bits of aen cfg
   hw/nvme: support smart AEN

  hw/nvme/ctrl.c       | 9 ++++++++-
  include/block/nvme.h | 8 +++++++-
  2 files changed, 15 insertions(+), 2 deletions(-)


I'm not quite sure what you are trying to achieve here. Bits 0 through 7
are reserved in OAES, they are not optional.

We already simply accept whatever the host configured with the
Asynchronous Event Configuration feature. And you added the support for
triggering custom AENs for those through the monitor.

Oh, sorry, I misunderstand OAES[7:0]. Thanks for pointing this out!

--
zhenwei pi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]