[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/15] tests: make libqmp buildable for win32
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 03/15] tests: make libqmp buildable for win32 |
|
Date: |
Thu, 05 May 2022 12:52:03 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/libqmp.h | 2 ++
> tests/qtest/libqmp.c | 35 +++++++++++++++++++++++++++++------
> 2 files changed, 31 insertions(+), 6 deletions(-)
>
> diff --git a/tests/qtest/libqmp.h b/tests/qtest/libqmp.h
> index 94aa97328a17..772f18b73ba3 100644
> --- a/tests/qtest/libqmp.h
> +++ b/tests/qtest/libqmp.h
> @@ -20,8 +20,10 @@
> #include "qapi/qmp/qdict.h"
>
> QDict *qmp_fd_receive(int fd);
> +#ifndef G_OS_WIN32
What's the difference between G_OS_WIN32 and _WIN32?
We have 10 of the former, but >250 of the latter. If they are
effectively the same, we should pick one and stick to it.
[...]