Re: [PATCH 3/4] block: Print protocol-specific information

[Eric Blake]

On Tue, May 03, 2022 at 04:55:28PM +0200, Hanna Reitz wrote:
> Make bdrv_image_info_dump() print protocol-specific information.
> 
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
>  block/qapi.c | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

(and now I should probably go write a patch to expose protocol
information for NBD...)

> 
> diff --git a/block/qapi.c b/block/qapi.c
> index 293983cf82..169ea08f70 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -921,4 +921,9 @@ void bdrv_image_info_dump(ImageInfo *info)
>          bdrv_image_info_specific_dump(info->format_specific,
>                                        "Format specific information:\n");
>      }
> +
> +    if (info->has_protocol_specific) {
> +        bdrv_image_info_specific_dump(info->protocol_specific,
> +                                      "Protocol specific information:\n");
> +    }
>  }
> -- 
> 2.35.1
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org