qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/7] nbd reconnect on open


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v4 0/7] nbd reconnect on open
Date: Tue, 21 Dec 2021 17:17:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

13.12.2021 18:32, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

The functionality is reviewed, python testing part is not.

I've dropped the patch "qapi: make blockdev-add a coroutine command":
it's optional, I don't want to slow down the whole series because of it.

v4:
01-03: wording,  add Eric's r-b
others: small changes, never had an r-b

Vladimir Sementsov-Ogievskiy (7):
   nbd: allow reconnect on open, with corresponding new options
   nbd/client-connection: nbd_co_establish_connection(): return real
     error
   nbd/client-connection: improve error message of cancelled attempt
   iotests.py: add qemu_tool_popen()
   For qemu_io* functions support --image-opts argument, which conflicts
     with -f argument from qemu_io_args.
   Add qemu-io Popen constructor wrapper. To be used in the following new
     test commit.
   iotests: add nbd-reconnect-on-open test

  qapi/block-core.json                          |  9 ++-
  block/nbd.c                                   | 45 +++++++++++-
  nbd/client-connection.c                       | 59 ++++++++++-----
  tests/qemu-iotests/iotests.py                 | 36 ++++++----
  .../qemu-iotests/tests/nbd-reconnect-on-open  | 71 +++++++++++++++++++
  .../tests/nbd-reconnect-on-open.out           | 11 +++
  6 files changed, 199 insertions(+), 32 deletions(-)
  create mode 100755 tests/qemu-iotests/tests/nbd-reconnect-on-open
  create mode 100644 tests/qemu-iotests/tests/nbd-reconnect-on-open.out


Thanks for reviewing!

I do s/6.2/7.0/ fix to patch 1, restore subjects of patches 5,6 (which were 
somehow lost in transition v3->v4) and apply the series to my nbd branch.


--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]