qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 04/14] job.h: define unlocked functions


From: Stefan Hajnoczi
Subject: Re: [RFC PATCH v2 04/14] job.h: define unlocked functions
Date: Thu, 16 Dec 2021 16:51:05 +0000

On Thu, Nov 04, 2021 at 10:53:24AM -0400, Emanuele Giuseppe Esposito wrote:
> All these functions assume that the lock is not held, and acquire
> it internally.
> 
> These functions will be useful when job_lock is globally applied,
> as they will allow callers to access the job struct fields
> without worrying about the job lock.
> 
> Update also the comments in blockjob.c (and move them in job.c).
> 
> Note: at this stage, job_{lock/unlock} and job lock guard macros
> are *nop*.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
>  include/qemu/job.h | 21 +++++++++++
>  blockjob.c         | 20 -----------
>  job.c              | 88 ++++++++++++++++++++++++++++++++++++++++++++--
>  3 files changed, 107 insertions(+), 22 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]