[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 24/25] python: re-enable pylint duplicate-code warnings
|
From: |
Beraldo Leal |
|
Subject: |
Re: [PATCH v2 24/25] python: re-enable pylint duplicate-code warnings |
|
Date: |
Thu, 16 Dec 2021 11:18:30 -0300 |
On Wed, Dec 15, 2021 at 02:39:38PM -0500, John Snow wrote:
> With the old library gone, there's nothing duplicated in the tree, so
> the warning suppression can be removed.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/setup.cfg | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 5140a5b322..c341e922c2 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -114,7 +114,6 @@ ignore_missing_imports = True
> disable=consider-using-f-string,
> too-many-function-args, # mypy handles this with less false
> positives.
> no-member, # mypy also handles this better.
> - duplicate-code, # To be removed by the end of this patch series.
>
> [pylint.basic]
> # Good variable names which should always be accepted, separated by a comma.
Reviewed-by: Beraldo Leal <bleal@redhat.com>
--
Beraldo
- [PATCH v2 19/25] python: temporarily silence pylint duplicate-code warnings, (continued)
- [PATCH v2 19/25] python: temporarily silence pylint duplicate-code warnings, John Snow, 2021/12/15
- [PATCH v2 21/25] python/aqmp: fully separate from qmp.QEMUMonitorProtocol, John Snow, 2021/12/15
- [PATCH v2 20/25] python/aqmp: take QMPBadPortError and parse_address from qemu.qmp, John Snow, 2021/12/15
- [PATCH v2 24/25] python: re-enable pylint duplicate-code warnings, John Snow, 2021/12/15
- [PATCH v2 25/25] python: rename qemu.aqmp to qemu.qmp, John Snow, 2021/12/15
[PATCH v2 22/25] python/aqmp: copy qmp docstrings to qemu.aqmp.legacy, John Snow, 2021/12/15
[PATCH v2 23/25] python: remove the old QMP package, John Snow, 2021/12/15