|
From: | Hanna Reitz |
Subject: | Re: [PATCH v5 06/31] block/block-backend.c: assertions for block-backend |
Date: | Fri, 10 Dec 2021 16:37:53 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> --- block/block-backend.c | 83 ++++++++++++++++++++++++++++++++++++++++++ softmmu/qdev-monitor.c | 2 + 2 files changed, 85 insertions(+)
So given my thoughts on patch 5, I believe that blk_set_perm() and blk_get_perm() should get assertions here.
Hanna
[Prev in Thread] | Current Thread | [Next in Thread] |