[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/13] Eliminate drive_get_next()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 00/13] Eliminate drive_get_next() |
Date: |
Mon, 06 Dec 2021 16:28:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> drive_get_next() is basically a bad idea. It returns the "next" block
> backend of a certain interface type. "Next" means bus=0,unit=N, where
> subsequent calls count N up from zero, per interface type.
>
> This lets you define unit numbers implicitly by execution order. If
> the order changes, or new calls appear "in the middle", unit numbers
> change. ABI break. Hard to spot in review. Replace its uses by
> drive_get(), then delete it.
Queued for 7.0.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 00/13] Eliminate drive_get_next(),
Markus Armbruster <=