|
From: | Max Reitz |
Subject: | Re: [PATCH v2 01/33] block: rename bdrv_replace_child to bdrv_replace_child_tran |
Date: | Mon, 31 May 2021 14:52:21 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote:
We have bdrv_replace_child() wrapper on bdrv_replace_child_noperm(). But bdrv_replace_child() doesn't update permissions. It's rather strange, as normally it's expected that foo() should call foo_noperm() and update permissions. Let's rename and add comment. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- block.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |