|
From: | Emanuele Giuseppe Esposito |
Subject: | Re: [PATCH v4 09/15] qemu-iotests: extend the check script to support valgrind for python tests |
Date: | Fri, 28 May 2021 22:31:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
sys.exit(os.EX_USAGE) +qemu_valgrind = [] +if os.environ.get('VALGRIND_QEMU') == "y" and \ + os.environ.get('NO_VALGRIND') != "y": + valgrind_logfile = "--log-file=" + test_dir.strip()
a bit strange that you need to strip test_dir here.. Why?
Yep, it's unnecessary
+VALGRIND_QEMU -- {VALGRIND_QEMU} """ args = collections.defaultdict(str, self.get_env())commit subject sais "support valgrind", but actually we only add a variable. valgrind is not actually used yet.. I'd reflect it in commit subject somehow
will replace with "prepare supporting" Emanuele
[Prev in Thread] | Current Thread | [Next in Thread] |