[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 15/31] python: add pylint import exceptions
From: |
John Snow |
Subject: |
[PATCH v8 15/31] python: add pylint import exceptions |
Date: |
Thu, 27 May 2021 17:16:59 -0400 |
Pylint 2.5.x - 2.7.x have regressions that make import checking
inconsistent, see:
https://github.com/PyCQA/pylint/issues/3609
https://github.com/PyCQA/pylint/issues/3624
https://github.com/PyCQA/pylint/issues/3651
Pinning to 2.4.4 is worse, because it mandates versions of shared
dependencies that are too old for features we want in isort and mypy.
Oh well.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
python/qemu/machine/__init__.py | 3 +++
python/qemu/machine/machine.py | 2 +-
python/qemu/machine/qtest.py | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py
index 98302ea31e7..728f27adbed 100644
--- a/python/qemu/machine/__init__.py
+++ b/python/qemu/machine/__init__.py
@@ -22,6 +22,9 @@
# the COPYING file in the top-level directory.
#
+# pylint: disable=import-error
+# see: https://github.com/PyCQA/pylint/issues/3624
+# see: https://github.com/PyCQA/pylint/issues/3651
from .machine import QEMUMachine
from .qtest import QEMUQtestMachine, QEMUQtestProtocol
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index d33b02d2ce6..b62435528e2 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -38,7 +38,7 @@
Type,
)
-from qemu.qmp import (
+from qemu.qmp import ( # pylint: disable=import-error
QEMUMonitorProtocol,
QMPMessage,
QMPReturnValue,
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index e893ca3697a..93700684d1c 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -26,7 +26,7 @@
TextIO,
)
-from qemu.qmp import SocketAddrT
+from qemu.qmp import SocketAddrT # pylint: disable=import-error
from .machine import QEMUMachine
--
2.31.1
- [PATCH v8 05/31] python/machine: Disable pylint warning for open() in _pre_launch, (continued)
- [PATCH v8 05/31] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/27
- [PATCH v8 06/31] python/machine: disable warning for Popen in _launch(), John Snow, 2021/05/27
- [PATCH v8 07/31] python/machine: Trim line length to below 80 chars, John Snow, 2021/05/27
- [PATCH v8 08/31] iotests/297: add --namespace-packages to mypy arguments, John Snow, 2021/05/27
- [PATCH v8 09/31] python: create qemu packages, John Snow, 2021/05/27
- [PATCH v8 10/31] python: add qemu package installer, John Snow, 2021/05/27
- [PATCH v8 11/31] python: add VERSION file, John Snow, 2021/05/27
- [PATCH v8 12/31] python: add directory structure README.rst files, John Snow, 2021/05/27
- [PATCH v8 13/31] python: add MANIFEST.in, John Snow, 2021/05/27
- [PATCH v8 14/31] python: Add pipenv support, John Snow, 2021/05/27
- [PATCH v8 15/31] python: add pylint import exceptions,
John Snow <=
- [PATCH v8 16/31] python: move pylintrc into setup.cfg, John Snow, 2021/05/27
- [PATCH v8 19/31] python: add excluded dirs to flake8 config, John Snow, 2021/05/27
- [PATCH v8 18/31] python: move flake8 config to setup.cfg, John Snow, 2021/05/27
- [PATCH v8 17/31] python: add pylint to pipenv, John Snow, 2021/05/27
- [PATCH v8 20/31] python: Add flake8 to pipenv, John Snow, 2021/05/27
- [PATCH v8 21/31] python: move mypy.ini into setup.cfg, John Snow, 2021/05/27
- [PATCH v8 22/31] python: add mypy to pipenv, John Snow, 2021/05/27
- [PATCH v8 24/31] python/qemu: add isort to pipenv, John Snow, 2021/05/27
- [PATCH v8 23/31] python: move .isort.cfg into setup.cfg, John Snow, 2021/05/27
- [PATCH v8 25/31] python/qemu: add qemu package itself to pipenv, John Snow, 2021/05/27