[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 17/31] python: add pylint to pipenv
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v7 17/31] python: add pylint to pipenv |
Date: |
Wed, 26 May 2021 12:14:26 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 |
26.05.2021 03:24, John Snow wrote:
We are specifying >= pylint 2.8.x for several reasons:
1. For setup.cfg support, added in pylint 2.5.x
2. To specify a version that has incompatibly dropped
bad-whitespace checks (2.6.x)
3. 2.7.x fixes "unsubscriptable" warnings in Python 3.9
4. 2.8.x adds a new, incompatible 'consider-using-with'
warning that must be disabled in some cases.
These pragmas cause warnings themselves in 2.7.x.
Signed-off-by: John Snow <jsnow@redhat.com>
Not sure how to review this one, numbers looks like numbers, hashes looks like
hashes, so it's OK :)
I've tried to regenerate Pipfile.lock from venv, and I see that new generated
Pipfile.lock has same hashes..
Still, new generated Pipfile.lock has some additional entries: appdirs,
distlib, filelock, importlib-resources, packaging, pluggy, py, pyparsing, six,
tox, virtualenv.. Not sure is it OK.
Another differencies are:
for importlib-metadata:
"markers": "python_version < '3.8'" -> "markers": "python_version < '3.8' and
python_version < '3.8'"
(looks like a bug in pipenv, isn't it)
for zipp:
"markers": "python_version >= '3.6'" -> "markers": "python_version < '3.10'"
The thing I hope is: we will not have commits like this one often..
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
- Re: [PATCH v7 13/31] python: add MANIFEST.in, (continued)
- [PATCH v7 12/31] python: add directory structure README.rst files, John Snow, 2021/05/25
- [PATCH v7 10/31] python: add qemu package installer, John Snow, 2021/05/25
- [PATCH v7 11/31] python: add VERSION file, John Snow, 2021/05/25
- [PATCH v7 15/31] python: add pylint import exceptions, John Snow, 2021/05/25
- [PATCH v7 16/31] python: move pylintrc into setup.cfg, John Snow, 2021/05/25
- [PATCH v7 14/31] python: Add pipenv support, John Snow, 2021/05/25
- [PATCH v7 17/31] python: add pylint to pipenv, John Snow, 2021/05/25
- [PATCH v7 18/31] python: move flake8 config to setup.cfg, John Snow, 2021/05/25
- [PATCH v7 20/31] python: Add flake8 to pipenv, John Snow, 2021/05/25
- [PATCH v7 21/31] python: move mypy.ini into setup.cfg, John Snow, 2021/05/25
- [PATCH v7 19/31] python: add excluded dirs to flake8 config, John Snow, 2021/05/25
- [PATCH v7 24/31] python/qemu: add isort to pipenv, John Snow, 2021/05/25
- [PATCH v7 22/31] python: add mypy to pipenv, John Snow, 2021/05/25
- [PATCH v7 23/31] python: move .isort.cfg into setup.cfg, John Snow, 2021/05/25
- [PATCH v7 25/31] python/qemu: add qemu package itself to pipenv, John Snow, 2021/05/25