[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 13/25] python: add excluded dirs to flake8 config
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v6 13/25] python: add excluded dirs to flake8 config |
Date: |
Tue, 25 May 2021 11:50:27 -0400 |
On Wed, May 12, 2021 at 07:12:29PM -0400, John Snow wrote:
> Instruct flake8 to avoid certain well-known directories created by
> python tooling that it ought not check.
>
> Note that at-present, nothing actually creates a ".venv" directory; but
> it is in such widespread usage as a de-facto location for a developer's
> virtual environment that it should be excluded anyway. A forthcoming
> commit canonizes this with a "make venv" command.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/setup.cfg | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 9ecb2902006..f21a1c42fc0 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -21,6 +21,8 @@ packages = find_namespace:
>
> [flake8]
> extend-ignore = E722 # Prefer pylint's bare-except checks to flake8's
> +exclude = __pycache__,
> + .venv,
>
Given that the default set of exclusions (version control system
files) are not expected here, it LGTM to reset it with these.
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v6 06/25] python: add directory structure README.rst files, (continued)
[PATCH v6 09/25] python: add pylint import exceptions, John Snow, 2021/05/12
[PATCH v6 10/25] python: move pylintrc into setup.cfg, John Snow, 2021/05/12
[PATCH v6 08/25] python: Add pipenv support, John Snow, 2021/05/12
[PATCH v6 11/25] python: add pylint to pipenv, John Snow, 2021/05/12
[PATCH v6 12/25] python: move flake8 config to setup.cfg, John Snow, 2021/05/12
[PATCH v6 13/25] python: add excluded dirs to flake8 config, John Snow, 2021/05/12
- Re: [PATCH v6 13/25] python: add excluded dirs to flake8 config,
Cleber Rosa <=
[PATCH v6 14/25] python: Add flake8 to pipenv, John Snow, 2021/05/12
[PATCH v6 15/25] python: move mypy.ini into setup.cfg, John Snow, 2021/05/12
[PATCH v6 16/25] python: add mypy to pipenv, John Snow, 2021/05/12
[PATCH v6 17/25] python: move .isort.cfg into setup.cfg, John Snow, 2021/05/12
[PATCH v6 18/25] python/qemu: add isort to pipenv, John Snow, 2021/05/12