[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] block: Fix Transaction leak in bdrv_reopen_multiple()
From: |
Kevin Wolf |
Subject: |
[PATCH 2/2] block: Fix Transaction leak in bdrv_reopen_multiple() |
Date: |
Mon, 3 May 2021 13:05:55 +0200 |
Like other error paths, this one needs to call tran_finalize() and clean
up the BlockReopenQueue, too.
Fixes: CID 1452772
Fixes: 72373e40fbc7e4218061a8211384db362d3e7348
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 5c0ced6238..69615fabd1 100644
--- a/block.c
+++ b/block.c
@@ -4052,7 +4052,7 @@ int bdrv_reopen_multiple(BlockReopenQueue *bs_queue,
Error **errp)
ret = bdrv_flush(bs_entry->state.bs);
if (ret < 0) {
error_setg_errno(errp, -ret, "Error flushing drive");
- goto cleanup;
+ goto abort;
}
}
--
2.30.2
[PATCH 2/2] block: Fix Transaction leak in bdrv_reopen_multiple(),
Kevin Wolf <=
Re: [PATCH 2/2] block: Fix Transaction leak in bdrv_reopen_multiple(), Vladimir Sementsov-Ogievskiy, 2021/05/04
Re: [PATCH 0/2] block: Fix Transaction leaks, Vladimir Sementsov-Ogievskiy, 2021/05/04