[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 04/10] block: allow specifying name of block device for vm
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v6 04/10] block: allow specifying name of block device for vmstate storage |
Date: |
Tue, 20 Oct 2020 07:17:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 10/8/20 10:49 AM, Daniel P. Berrangé wrote:
>> Currently the vmstate will be stored in the first block device that
>> supports snapshots. Historically this would have usually been the
>> root device, but with UEFI it might be the variable store. There
>> needs to be a way to override the choice of block device to store
>> the state in.
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>
>> @@ -83,7 +83,7 @@ QEMU X.Y.Z monitor - type 'help' for more information
>> (qemu) savevm snap0
>> Error: Device 'file' is writable but does not support snapshots
>> (qemu) info snapshots
>> -No block device supports snapshots
>> +no block device can store vmstate for snapshot
>
> We're inconsistent on whether error messages start with a Capital.
Pervasive issue.
Starting with lower case plays more nicely with error_prepend().
> But our split-brain behavior is not made any worse by this patch.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
- [PATCH v6 00/10] migration: bring improved savevm/loadvm/delvm to QMP, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 02/10] migration: stop returning errno from load_snapshot(), Daniel P . Berrangé, 2020/10/08
- [PATCH v6 03/10] block: add ability to specify list of blockdevs during snapshot, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 01/10] block: push error reporting into bdrv_all_*_snapshot functions, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 04/10] block: allow specifying name of block device for vmstate storage, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 05/10] block: rename and alter bdrv_all_find_snapshot semantics, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 06/10] migration: control whether snapshots are ovewritten, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 07/10] migration: wire up support for snapshot device selection, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 08/10] migration: introduce a delete_snapshot wrapper, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 09/10] iotests: add support for capturing and matching QMP events, Daniel P . Berrangé, 2020/10/08
- [PATCH v6 10/10] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/10/08
- Re: [PATCH v6 00/10] migration: bring improved savevm/loadvm/delvm to QMP, Daniel P . Berrangé, 2020/10/15