Re: [PATCH] iotests/259: Fix reference output

[Eric Blake]

On 8/11/20 3:08 AM, Max Reitz wrote:
> The error message has changed recently, breaking the test.  Fix it.
>
> Fixes: a2b333c01880f56056d50c238834d62e32001e54
>         ("block: nbd: Fix convert qcow2 compressed to nbd")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/259.out | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

I'm happy to let this go through your iotests tree, or I can queue it 
through my NBD tree, whichever gets a 5.2 pull request first.  (Fixing 
it for -rc4 does not seem justified, even though it is annoying to have 
a release with the test broken)

> diff --git a/tests/qemu-iotests/259.out b/tests/qemu-iotests/259.out
> index e27b9ff38d..1aaadfda4e 100644
> --- a/tests/qemu-iotests/259.out
> +++ b/tests/qemu-iotests/259.out
> @@ -10,5 +10,5 @@ disk size: unavailable
>   
>   --- Testing creation for which the node would need to grow ---
>   Formatting 'TEST_DIR/t.IMGFMT', fmt=qcow2 size=67108864 preallocation=metadata
> -qemu-img: TEST_DIR/t.IMGFMT: Could not resize image: Image format driver does 
> not support resize
> +qemu-img: TEST_DIR/t.IMGFMT: Could not resize image: Cannot grow NBD nodes
>   *** done

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org