|
From: | Eric Blake |
Subject: | Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon |
Date: | Thu, 28 May 2020 13:36:20 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/28/20 10:37 AM, Kevin Wolf wrote:
cur_mon really needs to be coroutine-local as soon as we move monitor command handlers to coroutines and let them yield. As a first step, just remove all direct accesses to cur_mon so that we can implement this in the getter function later. Signed-off-by: Kevin Wolf <kwolf@redhat.com> ---
+++ b/monitor/misc.c
@@ -258,6 +258,7 @@ static void monitor_init_qmp_commands(void) /* Set the current CPU defined by the user. Callers must hold BQL. */ int monitor_set_cpu(Monitor *mon, int cpu_index) { + Monitor *cur_mon = monitor_cur(); CPUState *cpu;cpu = qemu_get_cpu(cpu_index);
Bogus hunk, after patch 1/12. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |