Re: [PATCH v5 4/5] qemu-img: Add convert --bitmaps option

[Eric Blake]

On 5/21/20 10:11 AM, Nir Soffer wrote:
> On Thu, May 21, 2020 at 1:01 AM Eric Blake <address@hidden> wrote:
> > Make it easier to copy all the persistent bitmaps of (the top layer
> > of) a source image along with its guest-visible contents, by adding a
> > boolean flag for use with qemu-img convert.  This is basically
> > shorthand, as the same effect could be accomplished with a series of
> > 'qemu-img bitmap --add' and 'qemu-img bitmap --merge -b source'
> > commands, or by QMP commands.
> >
> > Note that this command will fail in the same scenarios where 'qemu-img
> > measure --bitmaps' fails, when either the source or the destanation

destination

> > lacks persistent bitmap support altogether.
>
> If we remove --bitmaps option from qemu-img measure, we need to remove
> this note.

Or rather, adjust it to state that "this command will fail in the 
scenarios where 'qemu-img measure' omits a 'bitmaps size:' output line.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org