[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size
|
From: |
Roman Kagan |
|
Subject: |
Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size |
|
Date: |
Wed, 20 May 2020 23:34:12 +0300 |
On Wed, May 20, 2020 at 05:36:58PM +0200, Kevin Wolf wrote:
> Am 20.05.2020 um 10:06 hat Roman Kagan geschrieben:
> > The width of opt_io_size in virtio_blk_topology is 32bit.
>
> I think you mean virtio_blk_config?
I consulted virtio-v1.1 spec where the topology-related fields are
grouped in struct virtio_blk_topology; I didn't realize in Linux (and
therefore in QEMU) these fields lay directly on virtio_blk_config. So
yes, the log should read "virtio_blk_config", thanks for spotting!
> > Use the appropriate accessor to store it.
> >
> > Signed-off-by: Roman Kagan <address@hidden>
>
> Reviewed-by: Kevin Wolf <address@hidden>
>
Thanks,
Roman.
- Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks, (continued)
[PATCH v4 1/3] virtio-blk: store opt_io_size with correct size, Roman Kagan, 2020/05/20
[PATCH v4 3/3] block: make BlockConf.*_size properties 32-bit, Roman Kagan, 2020/05/20