|
From: | Eric Blake |
Subject: | Re: [PULL v2 7/7] qemu-img: Add bitmap sub-command |
Date: | Tue, 19 May 2020 13:23:39 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/19/20 12:52 PM, Eric Blake wrote:
On 5/19/20 11:18 AM, Eric Blake wrote:Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be+ case 'g': + granularity = cvtnum(optarg); + if (granularity < 0) { + error_report("Invalid granularity specified"); + return 1; + }Phooey. I forgot to commit my changes before creating the tag. v3 pull request coming up :(
For the record, I've now made it harder for myself to repeat this mistake, by doing:
$ cat > .git/hooks/sendemail-validate <<\EOF #!/bin/sh git diff-files --quiet --ignore-submodules -- || { echo "You have unstaged changes."; exit 1; } git diff-index --cached --quiet HEAD --ignore-submodules -- || { echo "Your index contains uncommitted changes."; exit 1; } $ chmod +x .git/hooks/sendemail-validate [thanks to John Snow for advice on IRC] -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |