Re: [PATCH v2 0/9] drop unallocated_blocks_are_zero

[Vladimir Sementsov-Ogievskiy]

Ping

The whole series reviewed by Eric, with only one grammar fix needed in 02 
commit message (and possible drop of ret2, up to maintainer).

07.05.2020 11:47, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> v2 (by Eric's review):
>
> 01: moved to the start of the series, add Eric's r-b
> 02: new
> 03-04: improve commit message
> 05: add Eric's r-b
> 06-08: improve commit message a bit, add Eric's r-b
> 09: typos and wording, rebase on 02
>
>
> This is first step to block-status refactoring, and solves most simple
> problem mentioned in my investigation of block-status described in
> the thread "backing chain & block status & filters":
>    https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html
>
>
> unallocated_blocks_are_zero doesn't simplify all the logic about
> block-status, and happily it's not needed, as shown by the following
> patches. So, let's get rid of it.
>
> Vladimir Sementsov-Ogievskiy (9):
>    qemu-img: convert: don't use unallocated_blocks_are_zero
>    block: inline bdrv_unallocated_blocks_are_zero()
>    block/vdi: return ZERO block-status when appropriate
>    block/vpc: return ZERO block-status when appropriate
>    block/crypto: drop unallocated_blocks_are_zero
>    block/iscsi: drop unallocated_blocks_are_zero
>    block/file-posix: drop unallocated_blocks_are_zero
>    block/vhdx: drop unallocated_blocks_are_zero
>    block: drop unallocated_blocks_are_zero
>
>   include/block/block.h     |  6 ------
>   include/block/block_int.h | 12 +++++++++++-
>   block.c                   | 15 ---------------
>   block/crypto.c            |  1 -
>   block/file-posix.c        |  3 ---
>   block/io.c                |  8 ++++----
>   block/iscsi.c             |  1 -
>   block/qcow2.c             |  1 -
>   block/qed.c               |  1 -
>   block/vdi.c               |  3 +--
>   block/vhdx.c              |  3 ---
>   block/vpc.c               |  3 +--
>   qemu-img.c                |  4 +---
>   13 files changed, 18 insertions(+), 43 deletions(-)


--
Best regards,
Vladimir