Re: [PATCH v4 9/9] iotests: rename and move 169 and 199 tests

[Vladimir Sementsov-Ogievskiy]

19.05.2020 12:07, Kevin Wolf wrote:
> Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
> > On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
> > > Rename bitmaps migration tests and move them to tests subdirectory to
> > > demonstrate new human-friendly test naming.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > > ---
> > >   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
> > >   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
> > >   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
> > >   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
> > >   4 files changed, 0 insertions(+), 0 deletions(-)
> > >   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
> > >   rename tests/qemu-iotests/{199.out => 
> > > tests/migrate-bitmaps-postcopy-test.out} (100%)
> > >   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
> > >   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> > >
> > > diff --git a/tests/qemu-iotests/199 
> > > b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > > similarity index 100%
> > > rename from tests/qemu-iotests/199
> > > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > > diff --git a/tests/qemu-iotests/199.out 
> > > b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > > similarity index 100%
> > > rename from tests/qemu-iotests/199.out
> > > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > > diff --git a/tests/qemu-iotests/169 
> > > b/tests/qemu-iotests/tests/migrate-bitmaps-test
> > > similarity index 100%
> > > rename from tests/qemu-iotests/169
> > > rename to tests/qemu-iotests/tests/migrate-bitmaps-test
> > > diff --git a/tests/qemu-iotests/169.out 
> > > b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
> > > similarity index 100%
> > > rename from tests/qemu-iotests/169.out
> > > rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
> >
> > I like the idea ... but the path name + file names get now quite long.
> > While you're at it, what about renaming the "qemu-iotests" directory to
> > just "iotests" or even just "io" now?
>
> Renames are always kind of painful. Do we have a real reason for the
> rename except that the paths feel a bit long subjectively?
>
> Of course, if we're renaming all files anyway, changing the directory
> name at the same time shouldn't give any additional pain, so it would be
> completely reasonable then. We're not renaming the test harness files,
> though, and even only two test cases in this patch.
>
> Maybe this final patch should stay RFC until we have the infrastructure
> in and then we can have a single series that moves all tests and also
> renames the directory? Maybe a not strictly necessary rename of the
> tooling would be bearable in the context of a mass rename of tests.

I'm absolutely not hurrying about this thing. And actual aim of the series is 
another. I even doubt that we will mass rename the tests: who knows what they 
all test?) I don't. Still we may rename some tests, and we'll create new named 
tests which is good enough.. OK, if I resend a new version, I'll add an RFC 
patch on renaming the directory, up to maintainers, take it now or not :)

--
Best regards,
Vladimir