Re: [PATCH v4 04/34] block: Add BdrvChildRole and BdrvChildRoleBits

[Eric Blake]

On 5/13/20 6:05 AM, Max Reitz wrote:
> This mask will supplement BdrvChildClass when it comes to what role (or
> combination of roles) a child takes for its parent.  It consists of
> BdrvChildRoleBits values (which is an enum).
>
> Because empty enums are not allowed, let us just start with it filled.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   include/block/block.h | 56 +++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 56 insertions(+)
>
> diff --git a/include/block/block.h b/include/block/block.h
> index bc42e507bb..86cffa9ffd 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -268,6 +268,62 @@ enum {
>       DEFAULT_PERM_UNCHANGED      = BLK_PERM_ALL & ~DEFAULT_PERM_PASSTHROUGH,
>   };
>   
> +/*
> + * Flags parent nodes give for the child nodes to specify what kind of
> + * role(s) they take.

Reads a bit awkwardly. Maybe:

Flags that parent nodes assign to child nodes to specify what kind of 
role(s) they take.

Touching up grammar doesn't affect code correctness, so:
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org