[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] When del child, next_child_index need to subtract 1. Oth
From: |
Alberto Garcia |
Subject: |
Re: [PATCH 1/2] When del child, next_child_index need to subtract 1. Otherwise, the index will get bigger and bigger. |
Date: |
Mon, 11 May 2020 12:10:54 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 11 May 2020 12:00:30 PM CEST, address@hidden wrote:
> diff --git a/block/quorum.c b/block/quorum.c
> index 6d7a56b..a8272fe 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -1096,6 +1096,7 @@ static void quorum_del_child(BlockDriverState *bs,
> BdrvChild *child,
> memmove(&s->children[i], &s->children[i + 1],
> (s->num_children - i - 1) * sizeof(BdrvChild *));
> s->children = g_renew(BdrvChild *, s->children, --s->num_children);
> + s->next_child_index--;
> bdrv_unref_child(bs, child);
This is not correct, quorum_del_child() allows you to remove any child
from the Quorum device, so nothing guarantees you that
next_child_index-1 is free.
Berto