[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/9] blockdev: Promote several bitmap functions to non-sta
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 4/9] blockdev: Promote several bitmap functions to non-static |
Date: |
Mon, 11 May 2020 11:48:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 08.05.20 20:03, Eric Blake wrote:
> The next patch will split blockdev.c, which will require accessing
> some previously-static functions from more than one .c file. But part
> of promoting a function to public is picking a naming scheme that does
> not reek of exposing too many internals (two of the three functions
> were named starting with 'do_'). To make future code motion easier,
> perform the function rename and non-static promotion into its own
> patch.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> include/block/block_int.h | 12 +++++++++++
> blockdev.c | 45 ++++++++++++++++-----------------------
> 2 files changed, 30 insertions(+), 27 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
> diff --git a/blockdev.c b/blockdev.c
> index b3c840ec0312..fbeb38437869 100644
> --- a/blockdev.c
> +++ b/blockdev.c
[...]
> @@ -2504,9 +2495,10 @@ out:
> aio_context_release(aio_context);
> }
>
> -static BdrvDirtyBitmap *do_block_dirty_bitmap_remove(
> - const char *node, const char *name, bool release,
> - BlockDriverState **bitmap_bs, Error **errp)
> +BdrvDirtyBitmap *block_dirty_bitmap_remove(const char *node, const char
> *name,
> + bool release,
> + BlockDriverState **bitmap_bs,
I’m not entirely sure what this parameter is even used for, but it
obviously doesn’t concern this patch.
Max
> + Error **errp)
> {
> BlockDriverState *bs;
> BdrvDirtyBitmap *bitmap;
signature.asc
Description: OpenPGP digital signature
[PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps, Eric Blake, 2020/05/08
[PATCH v3 4/9] blockdev: Promote several bitmap functions to non-static, Eric Blake, 2020/05/08
- Re: [PATCH v3 4/9] blockdev: Promote several bitmap functions to non-static,
Max Reitz <=
[PATCH v3 1/9] docs: Sort sections on qemu-img subcommand parameters, Eric Blake, 2020/05/08
[PATCH v3 2/9] qemu-img: Fix stale comments on doc location, Eric Blake, 2020/05/08
[PATCH v3 6/9] qemu-img: Add bitmap sub-command, Eric Blake, 2020/05/08
[PATCH v3 8/9] qemu-img: Add convert --bitmaps option, Eric Blake, 2020/05/08
[PATCH v3 9/9] iotests: Add test 291 to for qemu-img bitmap coverage, Eric Blake, 2020/05/08