[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v4 0/6] hmp, qmp: Add some commands to introspect virtio device
From: |
no-reply |
Subject: |
Re: [RFC v4 0/6] hmp, qmp: Add some commands to introspect virtio devices |
Date: |
Thu, 7 May 2020 13:11:59 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [RFC v4 0/6] hmp,qmp: Add some commands to introspect virtio devices
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
3c7adbc..1b8c458 master -> master
Switched to a new branch 'test'
e9975e2 hmp: add x-debug-virtio commands
5092215 qmp: add QMP command x-debug-virtio-queue-element
7572b3f qmp: add QMP command x-debug-virtio-queue-status
d7e8edc qmp: decode feature bits in virtio-status
ee6f64a qmp: add QMP command x-debug-virtio-status
09ea838 qmp: add QMP command x-debug-query-virtio
=== OUTPUT BEGIN ===
1/6 Checking commit 09ea838d52de (qmp: add QMP command x-debug-query-virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27:
new file mode 100644
total: 0 errors, 1 warnings, 180 lines checked
Patch 1/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/6 Checking commit ee6f64a61066 (qmp: add QMP command x-debug-virtio-status)
3/6 Checking commit d7e8edc95598 (qmp: decode feature bits in virtio-status)
4/6 Checking commit 7572b3f9ba58 (qmp: add QMP command
x-debug-virtio-queue-status)
5/6 Checking commit 50922154ae8c (qmp: add QMP command
x-debug-virtio-queue-element)
6/6 Checking commit e9975e214541 (hmp: add x-debug-virtio commands)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67:
new file mode 100644
ERROR: spaces required around that '*' (ctx:WxV)
#346: FILE: hw/virtio/virtio.c:4097:
+ type##FeatureList *list = features->device->u.field.data; \
^
total: 1 errors, 1 warnings, 483 lines checked
Patch 6/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [RFC v4 1/6] qmp: add QMP command x-debug-query-virtio, (continued)
- [RFC v4 1/6] qmp: add QMP command x-debug-query-virtio, Laurent Vivier, 2020/05/07
- [RFC v4 2/6] qmp: add QMP command x-debug-virtio-status, Laurent Vivier, 2020/05/07
- [RFC v4 3/6] qmp: decode feature bits in virtio-status, Laurent Vivier, 2020/05/07
- [RFC v4 4/6] qmp: add QMP command x-debug-virtio-queue-status, Laurent Vivier, 2020/05/07
- [RFC v4 5/6] qmp: add QMP command x-debug-virtio-queue-element, Laurent Vivier, 2020/05/07
- [RFC v4 6/6] hmp: add x-debug-virtio commands, Laurent Vivier, 2020/05/07
Re: [RFC v4 0/6] hmp, qmp: Add some commands to introspect virtio devices,
no-reply <=