Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

[Igor Mammedov]

On Wed, 6 May 2020 10:39:02 +0200
Gerd Hoffmann <address@hidden> wrote:

>   Hi,
> 
> > >      crs = aml_resource_template();
> > >      aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
> > > -                           0x10, 0x02));
> > > +                           0x10, 0x08));
> > >      aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
> > > -    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE 
> > > + 2,
> > > -                           0x02, 0x06));  
> > can we just drop the later range as unused? (I don't see where it's 
> > actually initialized)  
> 
> I'd rather follow what physical hardware is doing here
> for better compatibility ...

maybe add comment here why it doesn't match IO range that RTC actualy provides,
otherwise it's looks very confusing

> 
> take care,
>   Gerd
>