[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/18] nvme: refactor nvme_addr_read
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v5 06/18] nvme: refactor nvme_addr_read |
Date: |
Tue, 05 May 2020 15:10:15 +0300 |
On Tue, 2020-05-05 at 07:52 +0200, Klaus Jensen wrote:
> On May 5 07:48, Klaus Jensen wrote:
> > From: Klaus Jensen <address@hidden>
> >
> > Pull the controller memory buffer check to its own function. The check
> > will be used on its own in later patches.
> >
> > Signed-off-by: Klaus Jensen <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Reviewed-by: Maxim Levitsky <address@hidden>
> > Reviewed-by: Keith Busch <address@hidden>
> > ---
> > hw/block/nvme.c | 16 ++++++++++++----
> > 1 file changed, 12 insertions(+), 4 deletions(-)
> >
>
> Woops, noticed that Maxim's R-b is wrong here, please update it to
>
> Reviewed-by: Maxim Levitsky <address@hidden>
>
> (without the 'y') when merging.
>
Well. When I worked for Intel, my email used to be address@hidden,
because I misspelled my private email (address@hidden) in my CV, and somehow
this got
propagated to my username there.
Sure enough when I applied to work for Red Hat, I triple checked this to avoid
such a mistake.
Well.... our usernames are limited to 8 characters.
Best regards,
Maxim Levitsky
- [PATCH v5 00/18] nvme: refactoring and cleanups, Klaus Jensen, 2020/05/05
- [PATCH v5 01/18] nvme: fix pci doorbell size calculation, Klaus Jensen, 2020/05/05
- [PATCH v5 03/18] nvme: remove superfluous breaks, Klaus Jensen, 2020/05/05
- [PATCH v5 06/18] nvme: refactor nvme_addr_read, Klaus Jensen, 2020/05/05
- [PATCH v5 04/18] nvme: move device parameters to separate struct, Klaus Jensen, 2020/05/05
- [PATCH v5 05/18] nvme: use constants in identify, Klaus Jensen, 2020/05/05
- [PATCH v5 08/18] nvme: remove redundant cmbloc/cmbsz members, Klaus Jensen, 2020/05/05
- [PATCH v5 02/18] nvme: rename trace events to pci_nvme, Klaus Jensen, 2020/05/05
- [PATCH v5 10/18] nvme: factor out device state setup, Klaus Jensen, 2020/05/05
- [PATCH v5 07/18] nvme: add max_ioqpairs device parameter, Klaus Jensen, 2020/05/05
- [PATCH v5 15/18] nvme: factor out cmb setup, Klaus Jensen, 2020/05/05
- [PATCH v5 14/18] nvme: factor out pci setup, Klaus Jensen, 2020/05/05
- [PATCH v5 09/18] nvme: factor out property/constraint checks, Klaus Jensen, 2020/05/05