Re: [PATCH v2 2/6] block/nbd-client: drop max_block restriction from discard

[Eric Blake]

On 4/21/20 4:56 PM, Eric Blake wrote:
> On 4/1/20 10:01 AM, Vladimir Sementsov-Ogievskiy wrote:
> > NBD spec is updated, so that max_block doesn't relate to
> > NBD_CMD_TRIM. So, drop the restriction.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> >   block/nbd.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I might tweak the commit message of 1/6 and here to call out the NBD 
> spec commit id (nbd.git 9f30fedb), but that doesn't change the patch 
> proper.

I'm queuing 1 and 2 through my NBD tree now; the rest involve more of 
the block layer and go in tandem with your other work on cleaning up 
64-bit operations throughout, and I still need to give that a better review.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org