[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate() |
|
Date: |
Mon, 04 May 2020 19:07:27 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote:
>> +_supported_fmt qcow2
>> +_supported_proto file
>
> Do we have to limit it to qcow2 and file? Yes, it's testing a bugfix
> for qcow2, but are there other formats that it doesn't hurt to have
> the extra testing?
It doesn't work with any other format at the moment (meaning: reading
the tail of the image after growing it returns the data from the backing
file).
Also, it seems that qemu-img's -F does not work with other formats
either.
> Also, I don't see anything preventing this from working with non-file
> protocol.
Right, that can be updated I guess (whoever commits this, feel free to
do it).
Berto
Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate(), no-reply, 2020/05/05