Re: [PATCH] Fix iotest 153

[Maxim Levitsky]

On Mon, 2020-05-04 at 11:22 +0200, Max Reitz wrote:
> On 03.05.20 18:49, Maxim Levitsky wrote:
> > Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o "" 
> > but this test uses it
> > 
> > Since this test only tries to do a dry-run run of qemu-img amend, replace 
> > the -o "" with
> > dummy -o "size=0" since due to the nature of the test, it is not going
> > to reach the actual amend operation anyway
> > 
> > Fixes: f62514b3def5fb2acbef64d0e053c0c31fa45aff
> > 
> > Signed-off-by: Maxim Levitsky <address@hidden>
> > ---
> >  tests/qemu-iotests/153     |  2 +-
> >  tests/qemu-iotests/153.out | 12 ++++++------
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
> > index 2b13111768..3f5029dd8f 100755
> > --- a/tests/qemu-iotests/153
> > +++ b/tests/qemu-iotests/153
> > @@ -122,7 +122,7 @@ for opts1 in "" "read-only=on" 
> > "read-only=on,force-share=on"; do
> >          _run_cmd $QEMU_IMG check       $L "${TEST_IMG}"
> >          _run_cmd $QEMU_IMG compare     $L "${TEST_IMG}" "${TEST_IMG}"
> >          _run_cmd $QEMU_IMG map         $L "${TEST_IMG}"
> > -        _run_cmd $QEMU_IMG amend -o "" $L "${TEST_IMG}"
> > +        _run_cmd $QEMU_IMG amend -o "size=0" $L "${TEST_IMG}"
> 
> AFAIU we don’t want this command to actually change the image (hence the
> empty options list, which would result in nothing being changed), so
> maybe "size=$size" would be more in the spirit of the test?

This is a good idea! Should I resend the patch or you can add this change 
locally?

Best regards,
        Maxim Levitsky


> 
> Max
>