|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v2 1/3] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section |
Date: | Mon, 4 May 2020 10:52:06 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 4/30/20 9:59 AM, Kevin Wolf wrote:
Am 30.04.2020 um 08:57 hat Philippe Mathieu-Daudé geschrieben:Keep an eye on these "same same, but different" files. Acked-by: Alex Bennée <address@hidden> Signed-off-by: Philippe Mathieu-Daudé <address@hidden> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8cbc1fac2b..7a7f2b9c31 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2083,6 +2083,7 @@ R: Philippe Mathieu-Daudé <address@hidden> S: Maintained F: gdbstub* F: gdb-xml/ +F: scripts/qemugdb/Wouldn't it make sense to add scripts/qemu-gdb.py as well?
I agree scripts/qemu-gdb.py with scripts/qemugdb/*py, but now looking at the files closely I don't think they belong to the gdbstub section (GDB protocol, with no knowledge of Python), and rather deserve a new section (GDB Python scripts, with no knowledge of GDB protocol).
I am discarding this patch. Regards, Phil.
Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |